Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript conversion #117

Merged
merged 11 commits into from
Feb 4, 2020
Merged

TypeScript conversion #117

merged 11 commits into from
Feb 4, 2020

Conversation

NaridaL
Copy link
Collaborator

@NaridaL NaridaL commented Jan 26, 2020

WIP

@NaridaL NaridaL changed the title Dev/ts TypeScript conversion Jan 26, 2020
@coveralls
Copy link

coveralls commented Feb 2, 2020

Coverage Status

Coverage decreased (-3.1%) to 89.432% when pulling e7846ef on NaridaL:dev/ts into ecddf42 on mobxjs:master.

@NaridaL
Copy link
Collaborator Author

NaridaL commented Feb 2, 2020

coveralls drop is due to more lines because of prettier.

I'm going to review this in a couple of days. The I've made some slight breaking changes wrt the "*" feature so I intend to release as a 2.0 version. I will use the opportunity to do make some other necessary changes (e.g. #77 )

@NaridaL
Copy link
Collaborator Author

NaridaL commented Feb 2, 2020

@danfma This should fix your issue. If you want to check out the branch and test it with your project, that would be very helpful!

@danfma
Copy link
Contributor

danfma commented Feb 2, 2020

Thank you! I will try that, but actually I solved that by transpiling all the serializr code also.

@NaridaL NaridaL merged commit aa023d2 into mobxjs:master Feb 4, 2020
@NaridaL NaridaL deleted the dev/ts branch February 4, 2020 19:55
NaridaL added a commit that referenced this pull request Feb 4, 2020
Convert to TypeScript

var -> const,let

Updated CHANGELOG.md

See Changelog for 2 minor breaking changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants