Add support for namespaces and fix imports

mobxjs · Feb 9, 2022 · d4af3bd · d4af3bd
1 parent b4fc9c4
commit d4af3bd
Show file tree

Hide file tree

Showing 3 changed files with 314 additions and 158 deletions.
diff --git a/packages/eslint-plugin-mobx/__tests__/missing-make-observable.js b/packages/eslint-plugin-mobx/__tests__/missing-make-observable.js
@@ -1,38 +1,42 @@
-import { RuleTester } from "eslint";
+import { RuleTester } from "eslint"
 
-import rule from "../src/missing-make-observable.js";
+import rule from "../src/missing-make-observable.js"
 
 const tester = new RuleTester({
-  parser: require.resolve('@typescript-eslint/parser'),
-  parserOptions: {}
-});
+    parser: require.resolve("@typescript-eslint/parser"),
+    parserOptions: {}
+})
 
 const fields = [
-  '@observable o = 5',
-  '@observable.ref or = []',
-  '@observable.shallow os = []',
-  '@observable.deep od = {}',
-  '@computed get c() {}',
-  '@computed.struct get cs() {}',
-  '@computed({ equals }) get co() {}',
-  '@action a() {}',
-  '@action.bound ab() {}',
-  '@flow *f() {}',
-  '@flow.bound *fb() {}',
-];
-
-const valid1 = fields.map(field => `
+    "observable o = 5",
+    "observable.ref or = []",
+    "observable.shallow os = []",
+    "observable.deep od = {}",
+    "computed get c() {}",
+    "computed.struct get cs() {}",
+    "computed({ equals }) get co() {}",
+    "action a() {}",
+    "action.bound ab() {}",
+    "flow *f() {}",
+    "flow.bound *fb() {}"
+]
+
+const valid1 = fields
+    .map(
+        field => `
 class C {     
-  ${field}
+  @${field}
 
   constructor() {
     makeObservable(this) 
   }      
 }
-`).map(code => ({ code }))
+`
+    )
+    .map(code => ({ code }))
 
 const valid2 = {
-  code: `
+    code: `
 class C {       
   o = 5;
   get c() {};
@@ -46,131 +50,204 @@ class C {
 `
 }
 
-const valid3 = fields.map(field => `
+const valid3 = fields
+    .map(
+        field => `
 class C {     
-  ${field}
+  @${field}
 
   constructor() {
     makeObservable(this, null, { name: 'foo' }) 
   }      
 }
-`).map(code => ({ code }))
+`
+    )
+    .map(code => ({ code }))
 
-const valid4 = fields.map(field => `
+const valid4 = fields
+    .map(
+        field => `
 class C {     
-  ${field}
+  @${field}
 
   constructor(aString: string);
   constructor(aNum: number);
   constructor(stringOrNum: string | number) {
     makeObservable(this, null, { name: 'foo' }) 
   }      
 }
-`).map(code => ({ code }))
+`
+    )
+    .map(code => ({ code }))
 
 const invalid1 = fields.map(field => ({
-  code: `
+    code: `
 class C {
-  ${field}
+  @${field}
 }
 `,
-  errors: [
-    { messageId: 'missingMakeObservable' },
-  ],
-  output: `
+    errors: [{ messageId: "missingMakeObservable" }],
+    output: `
 class C {
 constructor() { makeObservable(this); }
-  ${field}
+  @${field}
 }
 `
 }))
 
 const invalid2 = fields.map(field => ({
-  code: `
+    code: `
 class C {
-  ${field}
+  @${field}
   constructor() {}
 }
 `,
-  errors: [
-    { messageId: 'missingMakeObservable' },
-  ],
-  output: `
+    errors: [{ messageId: "missingMakeObservable" }],
+    output: `
 class C {
-  ${field}
+  @${field}
   constructor() {;makeObservable(this);}
 }
-`,
+`
 }))
 
 const invalid3 = fields.map(field => ({
-  code: `
+    code: `
 class C {
-  ${field}
+  @${field}
   constructor() {
     makeObservable({ a: 5 });
   }
 }
 `,
-  errors: [
-    { messageId: 'missingMakeObservable' },
-  ],
-  output: `
+    errors: [{ messageId: "missingMakeObservable" }],
+    output: `
 class C {
-  ${field}
+  @${field}
   constructor() {
     makeObservable({ a: 5 });
   ;makeObservable(this);}
 }
-`,
+`
 }))
 
 const invalid4 = fields.map(field => ({
-  code: `
+    code: `
 class C {
-  ${field}
+  @${field}
   constructor()
 }
 `,
-  errors: [
-    { messageId: 'missingMakeObservable' },
-  ],
-  output: `
+    errors: [{ messageId: "missingMakeObservable" }],
+    output: `
 class C {
-  ${field}
+  @${field}
   constructor() { makeObservable(this); }
 }
-`,
+`
 }))
 
-
 const invalid5 = fields.map(field => ({
-  code: `
+    code: `
 class C {
-  ${field}
+  @${field}
   constructor() {
     makeObservable(this, { o: observable.ref });
   }
 }
 `,
-  errors: [
-    { messageId: 'secondArgMustBeNullish' },
-  ],
+    errors: [{ messageId: "secondArgMustBeNullish" }]
+}))
+
+const invalid6 = fields.map(field => ({
+    code: `
+import * as mobx from 'mobx';
+
+class C {
+  @mobx.${field}
+}
+`,
+    errors: [{ messageId: "missingMakeObservable" }],
+    output: `
+import * as mobx from 'mobx';
+
+class C {
+constructor() { mobx.makeObservable(this); }
+  @mobx.${field}
+}
+`
+}))
+
+const invalid7 = fields.map(field => ({
+    code: `
+import { foo } from 'mobx';
+
+class C {
+  @${field}
+}
+`,
+    errors: [{ messageId: "missingMakeObservable" }],
+    output: `
+import { foo, makeObservable } from 'mobx';
+
+class C {
+constructor() { makeObservable(this); }
+  @${field}
+}
+`
 }))
 
+const invalid8 = fields.map(field => ({
+    code: `
+import { foo } from 'mobx';
+import * as mobx from 'mobx';
+
+class C {
+  @mobx.${field}
+}
+`,
+    errors: [{ messageId: "missingMakeObservable" }],
+    output: `
+import { foo } from 'mobx';
+import * as mobx from 'mobx';
+
+class C {
+constructor() { mobx.makeObservable(this); }
+  @mobx.${field}
+}
+`
+}))
+
+const invalid9 = fields.map(field => ({
+    code: `
+import { makeObservable as makeBanana } from 'mobx';
+
+class C {
+  @${field}
+}
+`,
+    errors: [{ messageId: "missingMakeObservable" }],
+    output: `
+import { makeObservable as makeBanana } from 'mobx';
+
+class C {
+constructor() { makeBanana(this); }
+  @${field}
+}
+`
+}))
 
 tester.run("missing-make-observable", rule, {
-  valid: [
-    ...valid1,
-    valid2,
-    ...valid3,
-    ...valid4,
-  ],
-  invalid: [
-    ...invalid1,
-    ...invalid2,
-    ...invalid3,
-    ...invalid4,
-    ...invalid5,
-  ],
-});
+    valid: [...valid1, valid2, ...valid3, ...valid4],
+    invalid: [
+        ...invalid1,
+        ...invalid2,
+        ...invalid3,
+        ...invalid4,
+        ...invalid5,
+        ...invalid6,
+        ...invalid7,
+        ...invalid8,
+        ...invalid9
+    ]
+})