Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added automatic generation of == and hashCode method with @StoreConfig #972

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amondnet
Copy link
Collaborator

@amondnet amondnet commented Dec 18, 2023

Describe the changes proposed in this Pull Request.

Added automatic generation of == and hasCode method with @StoreConfig


Pull Request Checklist

  • If the changes are being made to code, ensure the version in pubspec.yaml is updated.
  • Increment the major/minor/patch/patch-count, depending on the complexity of change
  • Add the necessary unit tests to ensure the coverage does not drop
  • Update the Changelog to include all changes made in this PR, organized by version
  • Run the melos run set_version command from the root directory
  • Include the necessary reviewers for the PR
  • Update the docs if there are any API changes or additions to functionality

Copy link

netlify bot commented Dec 18, 2023

👷 Deploy request for mobx pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit e5e72e5

@amondnet amondnet requested a review from pavanpodila December 18, 2023 09:07
@amondnet amondnet self-assigned this Dec 18, 2023
@amondnet amondnet requested a review from fzyzcjy December 18, 2023 09:08
@amondnet amondnet changed the title feat: Added automatic generation of == and hasCode method with @StoreConfig feat: Added automatic generation of == and hashCode method with @StoreConfig Dec 18, 2023
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Merging #972 (e5e72e5) into main (52515a1) will decrease coverage by 1.30%.
The diff coverage is 34.88%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #972      +/-   ##
==========================================
- Coverage   99.00%   97.70%   -1.30%     
==========================================
  Files          57       57              
  Lines        2005     2047      +42     
==========================================
+ Hits         1985     2000      +15     
- Misses         20       47      +27     
Flag Coverage Δ
flutter_mobx 100.00% <ø> (ø)
mobx 96.69% <0.00%> (-1.88%) ⬇️
mobx_codegen 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
mobx_codegen/lib/src/store_class_visitor.dart 100.00% <100.00%> (ø)
mobx_codegen/lib/src/template/store.dart 100.00% <100.00%> (ø)
mobx/lib/src/api/annotations.dart 80.00% <0.00%> (ø)
mobx/lib/src/api/store.dart 14.28% <0.00%> (-85.72%) ⬇️
mobx/lib/src/utils.dart 34.37% <0.00%> (-65.63%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52515a1...e5e72e5. Read the comment docs.

@amondnet amondnet force-pushed the override-equals-hash branch from f3dcc71 to e5e72e5 Compare December 18, 2023 09:10
@amondnet amondnet marked this pull request as draft December 19, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant