Fix SVG logos not displayed without width/height attribute #3845 #3863
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug fix.
Summary
In the masthead styles I changed the
max-height
of the site logo toheight
to allow for displaying SVG logos that don't have explicit width or height attributes set, which were previously rendered with 0 height, making them invisible.How This Change Will Affect Other Users
I have tried with multiple different combinations of logos and SVG attributes. This change won't affect the majority of users.
However, users who have a smaller logo which wasn't bound by the max-width of 2rem will now have a slightly bigger logo (2rem height), and of course the bug fix will affect users who were affected by the bug.
Context
This PR is related to the issue #3845 I opened.
Please confirm that you want to submit this Pull Request to Minimal Mistakes, the free Jekyll theme by Michael Rose, by deleting this comment block.