Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SVG logos not displayed without width/height attribute #3845 #3863

Closed
wants to merge 1 commit into from
Closed

Fix SVG logos not displayed without width/height attribute #3845 #3863

wants to merge 1 commit into from

Conversation

silvio2402
Copy link

This is a bug fix.

Summary

In the masthead styles I changed the max-height of the site logo to height to allow for displaying SVG logos that don't have explicit width or height attributes set, which were previously rendered with 0 height, making them invisible.

How This Change Will Affect Other Users

I have tried with multiple different combinations of logos and SVG attributes. This change won't affect the majority of users.
However, users who have a smaller logo which wasn't bound by the max-width of 2rem will now have a slightly bigger logo (2rem height), and of course the bug fix will affect users who were affected by the bug.

Context

This PR is related to the issue #3845 I opened.

Please confirm that you want to submit this Pull Request to Minimal Mistakes, the free Jekyll theme by Michael Rose, by deleting this comment block.

without width/height in masthead
@github-actions
Copy link

You have created a Pull Request to the wrong repository. This is the repository for Minimal Mistakes, the free Jekyll theme. See GitHub Docs: About pull requests if you need help.

@github-actions github-actions bot closed this Aug 15, 2022
@github-actions github-actions bot locked as spam and limited conversation to collaborators Aug 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant