Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: add machine label to "cs_active_decisions" #120

Closed
wants to merge 1 commit into from

Conversation

mmetc
Copy link
Owner

@mmetc mmetc commented Feb 28, 2024

No description provided.

Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help mmetc manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help mmetc manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 57.97%. Comparing base (8e9e091) to head (20216f5).

Files Patch % Lines
cmd/crowdsec/metrics.go 25.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #120   +/-   ##
=======================================
  Coverage   57.97%   57.97%           
=======================================
  Files         240      240           
  Lines       31040    31047    +7     
=======================================
+ Hits        17994    18000    +6     
- Misses      11416    11419    +3     
+ Partials     1630     1628    -2     
Flag Coverage Δ
bats 37.99% <25.00%> (-0.02%) ⬇️
unit-linux 52.26% <ø> (-0.01%) ⬇️
unit-windows 47.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc force-pushed the metrics-active-decisions-machine branch from 349aa05 to 2983aad Compare February 28, 2024 15:09
@mmetc mmetc force-pushed the metrics-active-decisions-machine branch from 2983aad to 20216f5 Compare February 28, 2024 15:28
@mmetc mmetc closed this Feb 28, 2024
@mmetc mmetc deleted the metrics-active-decisions-machine branch February 28, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant