Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: respect prototype arguments in dict -> dt conversion #966

Merged
merged 5 commits into from
Feb 8, 2024
Merged

feat: respect prototype arguments in dict -> dt conversion #966

merged 5 commits into from
Feb 8, 2024

Conversation

sebffischer
Copy link
Member

Previously, when adding learners with construction arguments that do not have defaults (such exist in mlr3torch), the Dictionary -> data.table conversion stopped working.

@sebffischer
feat: respect prototype arguments in dict -> dt conversion
8aa4b1c 
Previously, when adding learners with construction arguments
that do not have defaults (such exist in `mlr3torch`),
the `Dictionary` -> `data.table` conversion stopped working.
@sebffischer sebffischer marked this pull request as draft October 20, 2023 14:57
@sebffischer
Copy link
Member Author

sebffischer commented Oct 20, 2023 •
edited
Loading

sebffischer
sebffischer commented Oct 25, 2023
View reviewed changes
NEWS.md Outdated Show resolved Hide resolved
@sebffischer sebffischer mentioned this pull request Oct 26, 2023
Closed
@sebffischer sebffischer marked this pull request as ready for review February 7, 2024 16:00
@sebffischer sebffischer requested a review from be-marc February 7, 2024 16:00
@sebffischer sebffischer merged commit 9550ee1 into main Feb 8, 2024
3 checks passed
@sebffischer sebffischer deleted the fix/learner-dict branch February 8, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@be-marc be-marc Awaiting requested review from be-marc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sebffischer