Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop underscore from reserved keywords #184

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Drop underscore from reserved keywords #184

merged 4 commits into from
Nov 14, 2024

Conversation

davesnx
Copy link
Member

@davesnx davesnx commented Nov 14, 2024 •
edited
Loading

After this: #171 they were a few props that are reserved. Those need to appear as valid HTML and not JSX in the output.

This PR fixes that.

@davesnx davesnx merged commit 35b01e0 into main Nov 14, 2024
2 checks passed
@davesnx davesnx deleted the ensure-html-props-are-ok branch November 14, 2024 16:45
davesnx added a commit that referenced this pull request Nov 15, 2024
@davesnx
Merge branch 'main' of github.com:ml-in-barcelona/server-reason-react…
842b1f4 
… into use-state-cache

* 'main' of github.com:ml-in-barcelona/server-reason-react:
  Add link for private issue
  Drop underscore from reserved keywords (#184)
  Add test for let%private
  Implement let%private (#183)
  Update snapshots with 120
  Format to 120
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@davesnx