feat: add pexp_ident to @browser_only

packages/browser-ppx/ppx.ml

@@ -390,10 +390,13 @@ module Preprocess = struct
       method! expression expr =
         let expr = super#expression expr in
         match expr.pexp_desc with
-        | Pexp_apply _ | Pexp_constant _ ->
+        | Pexp_let (_, [ { pvb_attributes = attrs; _ } ], body) ->
+            let loc = expr.pexp_loc in
+            if should_keep expr.pexp_attributes = `keep then if should_keep attrs = `keep then expr else body
+            else [%expr ()]
+        | Pexp_apply _ | Pexp_constant _ | Pexp_ident _ ->
             let loc = expr.pexp_loc in
             if should_keep expr.pexp_attributes = `keep then expr else [%expr ()]
-        | Pexp_let (_, [ { pvb_attributes = attrs; _ } ], body) -> if should_keep attrs = `keep then expr else body
         | Pexp_fun _ ->
             if should_keep expr.pexp_attributes = `keep then expr
             else

packages/browser-ppx/tests/at_browser_only.t

@@ -131,17 +131,19 @@ Ppat_tuple
 Pexp_apply
 
   $ cat > input_apply.ml << EOF
-  > foo (42 [@browser_only]) ((fun () -> ())[@browser_only]) 24
+  > foo ((pexp_ident_var) [@browser_only]) ((42) [@browser_only]) ((fun () -> ())[@browser_only]) 24
   > EOF
 
   $ ./standalone.exe -impl input_apply.ml | ocamlformat - --enable-outside-detected-project --impl
-  foo ()
+  foo () ()
     (fun _ ->
       Runtime.fail_impossible_action_in_ssr "((fun () -> ())[@browser_only ])")
     24
 
   $ ./standalone.exe -impl input_apply.ml -js | ocamlformat - --enable-outside-detected-project --impl
-  foo (42 [@browser_only]) (fun [@browser_only] () -> ()) 24
+  foo (pexp_ident_var [@browser_only]) (42 [@browser_only])
+    (fun [@browser_only] () -> ())
+    24
 
 Ppat_var