Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update gitignore #112

Closed
wants to merge 1 commit into from
Closed

fix: Update gitignore #112

wants to merge 1 commit into from

Conversation

junland
Copy link

@junland junland commented Feb 17, 2024

This adds a git exceptions to zip files and klipper config files with the config directory that are generated when running prind.

This adds a git exceptions to `zip` files and klipper config files that are generated when running prind.
@mkuf
Copy link
Owner

mkuf commented Feb 17, 2024

Can you provide an example filename from your system that would be ignored by the config/printer-*.cfg pattern?
I do not have any files matching that pattern in my config directory.

@junland
Copy link
Author

junland commented Feb 17, 2024

Sure, something like this:

        config/printer-20240202_182533.cfg
        config/printer-20240202_201438.cfg
        config/printer-20240202_202852.cfg
        config/printer-20240204_210704.cfg
        config/printer-20240204_212522.cfg
        config/printer-20240204_223107.cfg
        config/printer-20240208_232126.cfg
        config/printer-20240208_235310.cfg
        config/printer-20240209_185309.cfg
        config/printer-20240211_030720.cfg
        config/printer-20240211_030736.cfg

@mkuf
Copy link
Owner

mkuf commented Feb 21, 2024

This would also target config/printer-simulavr.cfg, which is required by this project.

I suggest adding this change to your local working copy if you need it but at the current time I do not see any benefit from merging this into main.

Thanks for reaching out.
-Markus

@mkuf mkuf closed this Feb 21, 2024
@junland
Copy link
Author

junland commented Feb 22, 2024

Gotcha, no worries! Thank you for reviewing!

@junland junland deleted the patch-1 branch February 22, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants