Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for Reloop Mixage MK1, MK2, Controller Edition mappings for Mixxx 2.4 #592

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

HorstBaerbel
Copy link

@HorstBaerbel HorstBaerbel commented Nov 12, 2023

Copy link
Member

@ronso0 ronso0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, some first remarks, mainly simplifications / typos

source/hardware/controllers/reloop_mixage.rst Outdated Show resolved Hide resolved
source/hardware/controllers/reloop_mixage.rst Outdated Show resolved Hide resolved
source/hardware/controllers/reloop_mixage.rst Outdated Show resolved Hide resolved
source/hardware/controllers/reloop_mixage.rst Outdated Show resolved Hide resolved
source/hardware/controllers/reloop_mixage.rst Outdated Show resolved Hide resolved
source/hardware/controllers/reloop_mixage.rst Outdated Show resolved Hide resolved
source/hardware/controllers/reloop_mixage.rst Outdated Show resolved Hide resolved
source/hardware/controllers/reloop_mixage.rst Outdated Show resolved Hide resolved
source/hardware/controllers/reloop_mixage.rst Outdated Show resolved Hide resolved
source/hardware/controllers/reloop_mixage.rst Outdated Show resolved Hide resolved
@ronso0
Copy link
Member

ronso0 commented Dec 1, 2023

Thanks for applying all the fine tuning I suggested!
I take a final look once #12296 has been approved.

@HorstBaerbel HorstBaerbel requested a review from ronso0 December 3, 2023 12:12
source/hardware/controllers/reloop_mixage.rst Outdated Show resolved Hide resolved
source/hardware/controllers/reloop_mixage.rst Outdated Show resolved Hide resolved
source/hardware/controllers/reloop_mixage.rst Outdated Show resolved Hide resolved
source/hardware/controllers/reloop_mixage.rst Outdated Show resolved Hide resolved
@Swiftb0y
Copy link
Member

@ronso0 mixxxdj/mixxx#12296 is ready, can you give this your final review?

Copy link
Member

@ronso0 ronso0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits, the rest LGTM!

source/hardware/controllers/reloop_mixage.rst Outdated Show resolved Hide resolved
source/hardware/controllers/reloop_mixage.rst Outdated Show resolved Hide resolved
@ronso0
Copy link
Member

ronso0 commented Sep 21, 2024

Hmm, pre-commit is complaining, please run it locally or apply the patch generated by CI
https://github.com/mixxxdj/manual/actions/runs/10973237220?pr=592

@HorstBaerbel
Copy link
Author

Hmm, pre-commit is complaining, please run it locally or apply the patch generated by CI https://github.com/mixxxdj/manual/actions/runs/10973237220?pr=592

I just applied your suggestions

@ronso0
Copy link
Member

ronso0 commented Sep 21, 2024

I know, pre-commit points to other lines, just check the patch https://github.com/mixxxdj/manual/actions/runs/10973237220/artifacts/1961733470

@HorstBaerbel
Copy link
Author

Sorry, but I've moved on to a different controller. Maybe @gqzomer can integrate this?

@gqzomer
Copy link
Contributor

gqzomer commented Oct 21, 2024

I don't have a lot of time at the moment, I hope to have the time to look at the issue's sometime in December.

@ronso0
Copy link
Member

ronso0 commented Oct 21, 2024

Okay, I'll fix it then. There's an issue with trailing whitespaces and the SVG has been optimized.
I'll appy the fixes, squash the commits, push and merge soonish.

Thanks for your patience!

@ronso0 ronso0 force-pushed the 2.4 branch 2 times, most recently from b4b137c to 71fc5ea Compare October 21, 2024 15:16
@ronso0 ronso0 merged commit 170334d into mixxxdj:2.4 Oct 21, 2024
9 checks passed
@ronso0
Copy link
Member

ronso0 commented Oct 21, 2024

@HorstBaerbel I fixed this and pushed to your branch.
Please always pick a distinct name for feature branches, ie. don't use the upstream names (2.4), this can produce issues when rebasing and what not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants