-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation for Reloop Mixage MK1, MK2, Controller Edition mappings for Mixxx 2.4 #592
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, some first remarks, mainly simplifications / typos
Thanks for applying all the fine tuning I suggested! |
@ronso0 mixxxdj/mixxx#12296 is ready, can you give this your final review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nits, the rest LGTM!
Hmm, pre-commit is complaining, please run it locally or apply the patch generated by CI |
I just applied your suggestions |
I know, pre-commit points to other lines, just check the patch https://github.com/mixxxdj/manual/actions/runs/10973237220/artifacts/1961733470 |
Sorry, but I've moved on to a different controller. Maybe @gqzomer can integrate this? |
I don't have a lot of time at the moment, I hope to have the time to look at the issue's sometime in December. |
Okay, I'll fix it then. There's an issue with trailing whitespaces and the SVG has been optimized. Thanks for your patience! |
b4b137c
to
71fc5ea
Compare
Co-authored-by: ronso0 <[email protected]>
@HorstBaerbel I fixed this and pushed to your branch. |
Documentation for PR #12996.
https://deploy-preview-592--mixxx-manual.netlify.app/hardware/controllers/reloop_mixage