Skip to content

Commit

Permalink
Merge pull request #231 from mixpanel/fix-wrong-object
Browse files Browse the repository at this point in the history
Replace the MixpanelReactNative with mixpanelImpl and bump native versions
  • Loading branch information
zihejia authored Apr 11, 2024
2 parents fd6347d + bb5cce0 commit bbf5771
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion MixpanelReactNative.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@ Pod::Spec.new do |s|
s.pod_target_xcconfig = { 'DEFINES_MODULE' => 'YES' }

s.dependency "React-Core"
s.dependency "Mixpanel-swift", '4.2.4'
s.dependency "Mixpanel-swift", '4.2.5'
end
6 changes: 3 additions & 3 deletions android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ apply plugin: 'com.android.library'
android {
compileSdkVersion 33
buildToolsVersion "30.0.3"

def agpVersion = com.android.Version.ANDROID_GRADLE_PLUGIN_VERSION

if (agpVersion.tokenize('.')[0].toInteger() >= 7) {
namespace "com.mixpanel.reactnative"
}
Expand All @@ -41,5 +41,5 @@ repositories {

dependencies {
implementation 'com.facebook.react:react-native:+'
implementation 'com.mixpanel.android:mixpanel-android:7.3.2'
implementation 'com.mixpanel.android:mixpanel-android:7.5.0'
}
4 changes: 2 additions & 2 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ export class Mixpanel {
if (!ObjectHelper.isValidOrUndefined(properties)) {
ObjectHelper.raiseError(PARAMS.PROPERTIES);
}
MixpanelReactNative.track(this.token, eventName, {
this.mixpanelImpl.track(this.token, eventName, {
...Helper.getMetaData(),
...properties,
});
Expand Down Expand Up @@ -343,7 +343,7 @@ export class Mixpanel {
if (!ObjectHelper.isValidOrUndefined(properties)) {
ObjectHelper.raiseError(PARAMS.PROPERTIES);
}
MixpanelReactNative.trackWithGroups(
this.mixpanelImpl.trackWithGroups(
this.token,
eventName,
{
Expand Down

0 comments on commit bbf5771

Please sign in to comment.