add more tests

mixpanel · Oct 27, 2022 · 2013e44 · 2013e44
1 parent a39250b
commit 2013e44
Show file tree

Hide file tree

Showing 3 changed files with 70 additions and 9 deletions.
diff --git a/packages/destination-actions/src/destinations/mixpanel/identifyUser/__tests__/index.test.ts b/packages/destination-actions/src/destinations/mixpanel/identifyUser/__tests__/index.test.ts
@@ -77,7 +77,19 @@ describe('Mixpanel.identifyUser', () => {
     const event = createTestEvent({
       timestamp, traits: {
         firstName: 'Joe',
-        lastName: 'Doe',
+        lastName: 'Doe'
+      }
+    })
+
+    const event2 = createTestEvent({
+      timestamp, traits: {
+        firstName: 'Joe'
+      }
+    })
+
+    const event3 = createTestEvent({
+      timestamp, traits: {
+        lastName: 'Doe'
       }
     })
 
@@ -98,14 +110,62 @@ describe('Mixpanel.identifyUser', () => {
         data: JSON.stringify({
           $token: MIXPANEL_PROJECT_TOKEN,
           $distinct_id: 'user1234',
+          $ip: '8.8.8.8',
           $set: {
             $first_name: 'Joe',
             $last_name: 'Doe',
-            $name: 'Joe Doe',
+            $name: 'Joe Doe'
           }
         })
       })
     )
+    nock('https://api.mixpanel.com').post('/engage').reply(200, {})
+    nock('https://api.mixpanel.com').post('/track').reply(200, {})
+    const responses2 = await testDestination.testAction('identifyUser', {
+      event: event2,
+      useDefaultMappings: true,
+      settings: {
+        projectToken: MIXPANEL_PROJECT_TOKEN,
+        apiSecret: MIXPANEL_API_SECRET,
+        apiRegion: ApiRegions.US
+      }
+    })
+    expect(responses2[1].options.body).toMatchObject(
+      new URLSearchParams({
+        data: JSON.stringify({
+          $token: MIXPANEL_PROJECT_TOKEN,
+          $distinct_id: 'user1234',
+          $ip: '8.8.8.8',
+          $set: {
+            $first_name: 'Joe'
+          }
+        })
+      })
+    )
+    nock('https://api.mixpanel.com').post('/engage').reply(200, {})
+    nock('https://api.mixpanel.com').post('/track').reply(200, {})
+    const responses3 = await testDestination.testAction('identifyUser', {
+      event: event3,
+      useDefaultMappings: true,
+      settings: {
+        projectToken: MIXPANEL_PROJECT_TOKEN,
+        apiSecret: MIXPANEL_API_SECRET,
+        apiRegion: ApiRegions.US
+      }
+    })
+    expect(responses3[1].options.body).toMatchObject(
+      new URLSearchParams({
+        data: JSON.stringify({
+          $token: MIXPANEL_PROJECT_TOKEN,
+          $distinct_id: 'user1234',
+          $ip: '8.8.8.8',
+          $set: {
+            $last_name: 'Doe'
+          }
+        })
+      })
+    )
+
   })
 
   it('should use EU server URL', async () => {

diff --git a/packages/destination-actions/src/destinations/mixpanel/identifyUser/index.ts b/packages/destination-actions/src/destinations/mixpanel/identifyUser/index.ts
@@ -2,7 +2,7 @@ import { ActionDefinition, IntegrationError, omit } from '@segment/actions-core'
 import type { Settings } from '../generated-types'
 import type { Payload } from './generated-types'
 
-import { getApiServerUrl, getName } from '../utils'
+import { getApiServerUrl, getConcatenatedName } from '../utils'
 
 const action: ActionDefinition<Settings, Payload> = {
   title: 'Identify User',
@@ -73,18 +73,19 @@ const action: ActionDefinition<Settings, Payload> = {
     }
 
     if (payload.traits && Object.keys(payload.traits).length > 0) {
+      const concatenatedName = getConcatenatedName(
+        payload.traits.firstName,
+        payload.traits.lastName,
+        payload.traits.name
+      )
       const traits = {
         ...omit(payload.traits, ['created', 'email', 'firstName', 'lastName', 'name', 'username', 'phone']),
         // to fit the Mixpanel expectations, transform the special traits to Mixpanel reserved property
         $created: payload.traits.created,
         $email: payload.traits.email,
         $first_name: payload.traits.firstName,
         $last_name: payload.traits.lastName,
-        $name: getName(
-          payload.traits.firstName,
-          payload.traits.lastName,
-          payload.traits.name
-        ),
+        $name: concatenatedName,
         $username: payload.traits.username,
         $phone: payload.traits.phone
       }

diff --git a/packages/destination-actions/src/destinations/mixpanel/utils.ts b/packages/destination-actions/src/destinations/mixpanel/utils.ts
@@ -3,7 +3,7 @@ export enum ApiRegions {
   EU = 'EU 🇪🇺'
 }
 
-export function getName(firstName: unknown, lastName: unknown, name: unknown): unknown {
+export function getConcatenatedName(firstName: unknown, lastName: unknown, name: unknown): unknown {
   return (
     name ?? (firstName && lastName ? `${ firstName } ${ lastName }` : undefined)
   )