Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable annotations to service #241

Merged
merged 1 commit into from
May 23, 2024

Conversation

dannypas00
Copy link
Contributor

This adds configurable annotations to the service. This is sometimes necessary in cloud environments such as google to configure a backendconfig for health checks and other load balancing features:

service:
  type: ClusterIP
  port: 80
  target: 80
  annotations:
    cloud.google.com/backend-config: '{"default": "some-backendconfig"}'
    cloud.google.com/neg: '{"ingress": true}'

Copy link
Member

@martin-helmich martin-helmich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@martin-helmich martin-helmich enabled auto-merge (squash) May 23, 2024 06:26
@martin-helmich martin-helmich merged commit 2846c1f into mittwald:master May 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants