Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible_mitogen: Templated ssh executable #1175

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

moreati
Copy link
Member

@moreati moreati commented Oct 29, 2024

Adding a the tt-ssh-executable test target uncovered Ansible bug ansible/ansible#84238 during meta: reset_connection tasks. So this commit includes a workaround for affected versions of Ansible.

refs #1083,

@moreati moreati force-pushed the issue1083-ssh_executable branch 5 times, most recently from 805f628 to 7b86093 Compare October 29, 2024 15:23
@moreati
Copy link
Member Author

moreati commented Oct 29, 2024

Note to self: the Python interpreter discovery plumbing needs a Templar instance to expand a templated ansible_ssh_executable="{{ ... }}". During a meta: connection_reset the cut down ActionMixin just YOLOs templar=0.

@moreati moreati force-pushed the issue1083-ssh_executable branch 24 times, most recently from 4685627 to 07b1cfa Compare November 1, 2024 21:09
@moreati moreati force-pushed the issue1083-ssh_executable branch 10 times, most recently from e631747 to 72969d9 Compare November 4, 2024 14:40
… fix

Adding a the tt-ssh-executable test target uncovered an Ansible bug during
`meta: reset_connection` tasks. So this commit includes a workaround for
affected versions of Ansible.
@moreati moreati force-pushed the issue1083-ssh_executable branch from 72969d9 to 833e284 Compare November 4, 2024 15:17
@moreati
Copy link
Member Author

moreati commented Nov 4, 2024

Awaiting end of today's GitHub Actions macOS 12 (#1133) brownout to complete tests and merge.

@moreati moreati marked this pull request as ready for review November 4, 2024 16:09
@moreati moreati merged commit 88e7c56 into mitogen-hq:master Nov 5, 2024
24 checks passed
@moreati moreati deleted the issue1083-ssh_executable branch November 5, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant