ansible_mitogen: Support templated become_user

[mordekasg]

refs #1083

[moreati]

Thank you, but this PR has multiple issues

• as mentioned it needs to use the become plugin, not the connection plugin
• the changelog should be narrower in its claim
• It needs additional tests to confirm that templated become user now works, and that it will stay working in the future.

[moreati]

This is my work in progress for handling become plugin options

    # Better to use ActionBase.get_become_option? Probably not, as long as
    # ansible_mitogen.connection.Connection.reset() assigns a half lobotomised
    # self._action
    def _become_option(self, name):
        plugin = self._connection.become
        if plugin is not None:
            return plugin.get_option(
                name, hostvars=self._task_vars, playcontext=self._play_context,
            )
        else:
            # FIXME BecomeBase.get_option() only does this for become_user,
            #       become_pass, become_flags, & become_exe.
            LOG.warning(
                '%r: Used play_context fallback for option %r', self, name,
            )
            return getattr(self._play_context, name)

The FIXME is part of why it's still WIP, the other is that I haven't worked out how to test it yet.

[mordekasg]

This is my work in progress for handling become plugin options
[...]
The FIXME is part of why it's still WIP, the other is that I haven't worked out how to test it yet.

Should I close this PR? I feel like it`s not the best idea to leave this PR if you are already working on that topic.
Maybe it would be better to help you with testing?

[moreati]

Lets leave it open, in draft. It's as agood a place as any to collect notes, intermiediate test results and generally collaborate.

Have you manually tested your code change? Is it working for your playbook(s)?

[moreati]

Notes:

• Ansible PR become - stop using play context in more places ansible/ansible#62373
  • moved common become* parameters to become options
  • created ansible.plugins.become.BecomeBase.get_option() containing a limited getattr(play_context, ...) fallback
  • is present in all ansible-core >= 2.10
• ansible-core become plugins subclass BecomeBase. This may be a requirement of all Ansible become plugins.
• ansible_mitogen.plugins.connection.mitogen_sudo subclasses ConnectionBase, not BecomeBase.
• ansible_mitogen is entirely unaware of become plugins. Existing become support relies on legacy Ansible < 2.10 fallbacks.
• ansible_mitogen.transport_config.PlayContextSpec._connect_option() will silently return non-connection options such as become_user, due to the unrestricted getattr(play_context, ...) fallback.

[moreati]

Noticed several commented out tests related to become_user and become_pasword while looking at this. Probably not critical path for this feature, but I want to take a look soon. Refs #658, #692

$ ag https://github.com/dw/mitogen/issues/692 -A1   
ag https://github.com/dw/mitogen/issues/692 -A1       
tests/ansible/integration/playbook_semantics/with_items.yml
8:    # TODO: https://github.com/dw/mitogen/issues/692
9-    # - name: Spin up a few interpreters

tests/ansible/integration/action/make_tmp_path.yml
145:    # TODO: https://github.com/dw/mitogen/issues/692
146-    # - name: "Try writing to temp directory for the readonly_homedir user"

tests/ansible/integration/action/synchronize.yml
43:    # TODO: https://github.com/dw/mitogen/issues/692
44-    # - file:
--
73:    # TODO: https://github.com/dw/mitogen/issues/692
74-    # - file:

tests/ansible/integration/become/sudo_password.yml
62:    # TODO: https://github.com/dw/mitogen/issues/692
63-    # - name: Ensure password sudo succeeds.

tests/ansible/integration/become/sudo_requiretty.yml
8:    # TODO: https://github.com/dw/mitogen/issues/692
9-    # - name: Verify we can login to a non-passworded requiretty account
--
22:    # TODO: https://github.com/dw/mitogen/issues/692
23-    # - name: Verify we can login to a passworded requiretty account

[moreati]

@mordekasg I've updated the branch with what I think is the correct combination to get templated become_user working, plus tests to cover it. Could you try it and let me know if it works for you?. Comments, questions and code reviews welcomed.

I also added you to the list of contributers. If you'd prefer not to be listed or to change the entry, then please let me know.

[mordekasg]

Lets leave it open, in draft. It's as agood a place as any to collect notes, intermiediate test results and generally collaborate.

Have you manually tested your code change? Is it working for your playbook(s)?

I tested my change then and now - you were right, it`s not working or working randomly.

@mordekasg I've updated the branch with what I think is the correct combination to get templated become_user working, plus tests to cover it. Could you try it and let me know if it works for you?. Comments, questions and code reviews welcomed.

Thank you! Will try to do it today.

[mordekasg]

@moreati
Tested - everything is working flawlessly.
I have also done some runs on my infrastructure and nothing crashed - LGTM.

[moreati]

Tested - everything is working flawlessly.
I have also done some runs on my infrastructure and nothing crashed - LGTM.

thank you, great news.

The code reviewed has been replaced by commits I made