Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve i18n for 'Copy to backpack' option in multiselect #43

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve i18n for 'Copy to backpack' option in multiselect #43

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5c2b0d
Improve i18n for 'Copy to backpack' option in multiselect
ewpatton Feb 29, 2024
67995f4
Fix linting errors
ewpatton Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/multiselect_contextmenu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -768,7 +768,6 @@ const updateToMultiCopyToBackpack =
if (!backpack) {
return '';
}
const backpackCount = backpack.getCount();
let workableBlocksLength = 0;
const blockSelection = blockSelectionWeakMap.get(ws);
if (!blockSelection.size) {
Expand All @@ -781,8 +780,17 @@ const updateToMultiCopyToBackpack =
workableBlocksLength++;
}
}
return `(${workableBlocksLength}) ` +
`${Blockly.Msg['COPY_TO_BACKPACK']} (${backpackCount})`;
if (workableBlocksLength > 1) {
if (Blockly.Msg['COPY_X_TO_BACKPACK']) {
return Blockly.Msg['COPY_X_TO_BACKPACK']
.replace('%1', workableBlocksLength.toString());
} else {
return Blockly.Msg['COPY_TO_BACKPACK'] +
` (${workableBlocksLength})`;
}
} else {
return Blockly.Msg['COPY_TO_BACKPACK'];
}
},
preconditionFn: function(scope) {
if (!scope.block) return 'hidden';
Expand Down