Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ListAccessKeysBulk #303

Merged
merged 5 commits into from
Sep 14, 2024
Merged

Add ListAccessKeysBulk #303

merged 5 commits into from
Sep 14, 2024

Conversation

taran-p
Copy link
Contributor

@taran-p taran-p commented Sep 4, 2024

Adds ListAccessKeysBulk API to bring ListAccessKeysLDAPBulk features to builtin access key listing. Moves ListAccessKeysLDAP/Bulk to idp-commands.go for consistency

@taran-p taran-p requested a review from donatello September 4, 2024 18:46
idp-commands.go Outdated Show resolved Hide resolved
idp-commands.go Outdated Show resolved Hide resolved
idp-commands.go Outdated Show resolved Hide resolved
user-commands.go Outdated Show resolved Hide resolved
@harshavardhana harshavardhana merged commit 06b32c3 into minio:main Sep 14, 2024
9 checks passed
@harshavardhana
Copy link
Member

as I have said many times before we do not break published APIs

Run TAG="quay.io/minio/minio:9eea7be" make docker
Checking dependencies
Building minio binary to './minio'
# github.com/minio/mc/cmd
Error: ../../../../go/pkg/mod/github.com/minio/[email protected][4](https://github.com/minio/minio/actions/runs/10862159172/job/30144865752?pr=20436#step:6:5)0909075310-04c5116c9bdf/cmd/idp-ldap-accesskey-list.go:186:84: too many arguments in call to client.ListAccessKeysLDAPBulk
	have (context.Context, []string, string, bool)
	want (context.Context, []string, madmin.ListAccessKeysOpts)
Error: ../../../../go/pkg/mod/github.com/minio/[email protected][5](https://github.com/minio/minio/actions/runs/10862159172/job/30144865752?pr=20436#step:6:6)310-04c5116c9bdf/cmd/idp-ldap-accesskey-list.go:190:85: too many arguments in call to client.ListAccessKeysLDAPBulk
	have (context.Context, []string, string, bool)
	want (context.Context, []string, madmin.ListAccessKeysOpts)
make: *** [Makefile:1[7](https://github.com/minio/minio/actions/runs/10862159172/job/30144865752?pr=20436#step:6:8)1: build] Error 1
Error: Process completed with exit code 2.

https://github.com/minio/minio/actions/runs/10862159172/job/30144865752?pr=20436

We own the mistakes we did in the past

@taran-p
Copy link
Contributor Author

taran-p commented Sep 14, 2024

Understood, original PR did not break API, I can revert to that and resubmit if needed.

@harshavardhana
Copy link
Member

harshavardhana commented Sep 14, 2024

Understood, original PR did not break API, I can revert to that and resubmit if needed.

Already fixed .. it did break the LDAP bulk() became option pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants