Add drive model to partitions in health report #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Capture the drive model in partitions data in the health report. It will be read from `/sys/class/block/<drive-name>/device/model`
balamurugana
approved these changes
Sep 27, 2023
Thanks @balamurugana , I've updated the code to do this. PTAL. |
anjalshireesh
force-pushed
the
health
branch
2 times, most recently
from
71fe9c5 to
f9a864e
Compare
anjalshireesh
force-pushed
the
health
branch
from
f9a864e to
dd464f8
Compare
balamurugana
approved these changes
Sep 28, 2023
shtripat
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
LGTM. Verified with health report generated.
{
"device": "/dev/nvme0n1p3",
"model": "KXG6AZNV512G TOSHIBA",
"mountpoint": "/",
"fs_type": "btrfs",
"mount_options": "rw,relatime,bind",
"mount_fs_type": "btrfs",
"space_total": 510405902336,
"space_free": 271951970304
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capture the drive model in partitions data in the health report. It will be read from
/run/udev/data/b<major>:<minor>