Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add HMAC API test #434

Merged
merged 1 commit into from
Jan 17, 2024
Merged

add HMAC API test #434

merged 1 commit into from
Jan 17, 2024

Conversation

aead
Copy link
Member

@aead aead commented Jan 15, 2024

This commit adds tests for the HMAC server API.
It also removes enclave code that is no longer used nor supported.

Requires minio/kms-go#9

@aead aead requested review from shtripat and allanrogerr January 15, 2024 19:42
@shtripat
Copy link
Contributor

Do we need go.mod changes for kes-go to clear of build fails?

@aead
Copy link
Member Author

aead commented Jan 16, 2024

As the commit/PR message says, we need to merge minio/kms-go#9 first and then update the go mod dependency.

This commit adds tests for the HMAC server API.
It also removes enclave code that is no longer used
nor supported.

Signed-off-by: Andreas Auernhammer <[email protected]>
@aead
Copy link
Member Author

aead commented Jan 16, 2024

SDK PR is merged 🎉

Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aead aead merged commit 06d53c9 into master Jan 17, 2024
7 checks passed
@aead aead deleted the hmac-test branch January 17, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants