Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHELPLAN-171066 - add xxhash to gcc-misc #1328

Closed
wants to merge 2 commits into from
Closed

Conversation

fche
Copy link
Contributor

@fche fche commented Nov 26, 2024

cc: @hhorak

Copy link

@siddhesh siddhesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reckon the xxhash entry also needs to be dropped from configs/sst_kernel_security-unwanted.yaml.

configs/sst_pt_gcc-misc.yaml Show resolved Hide resolved
@hhorak
Copy link
Contributor

hhorak commented Nov 27, 2024

cc: @hhorak

LGTM

@yselkowitz
Copy link
Collaborator

Based on the discussion above, this package is going to be buildroot-only for now. Therefore, I see no need to list it in CR, it will be (and in ELN already is) pulled in automatically as a build dependency of the affected packages (starting with dwz). If at some point in the future you decide to ship xxhash -- e.g. if a package starts using it NOT in header-only inline mode, causing xxhash-libs to be a runtime dependency, and in which case the other subpackages should go into CRB -- then this would be the correct change to make.

@yselkowitz yselkowitz closed this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants