Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop google-benchmark #1275

Closed
wants to merge 1 commit into from
Closed

Drop google-benchmark #1275

wants to merge 1 commit into from

Conversation

liutgnu
Copy link
Contributor

@liutgnu liutgnu commented Aug 22, 2024

Ticket: RHELMISC-6531

Ticket: RHELMISC-6531

Signed-off-by: Tao Liu <[email protected]>
Copy link
Collaborator

@yselkowitz yselkowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That won't quite do what you're intending. Instead, I suggest changing unwanted_packages to unwanted_source_packages and dropping the defunct crash-ptdump-command.

@liutgnu
Copy link
Contributor Author

liutgnu commented Aug 29, 2024

Hi @yselkowitz ,

That won't quite do what you're intending. Instead, I suggest changing unwanted_packages to unwanted_source_packages and dropping the defunct crash-ptdump-command.

Thanks for your help. I guess the MR is no longer needed because the package has already been dropped and the process of dropping has been done. So I will close the MR. Thanks again for your help!

Thanks,
Tao Liu

@liutgnu liutgnu closed this Aug 29, 2024
@yselkowitz
Copy link
Collaborator

Marking a package as unwanted never triggered its removal, but the PR is still useful as it will flag this should another package begin to depend on this in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants