Upgrade to .NET 8.0 and refactor input value extraction #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramioh
commented
Oct 15, 2024
Comment on lines
+34
to
+36
| var fieldValues = type | ||
| .GetFields(BindingFlags.Public | BindingFlags.Instance) | ||
| .Select(field => new { field.Name, Value = field.GetValue(valueObject) }); |
There was a problem hiding this comment.
The old code had a check to exclude a field by name if it was previously added as a property. I removed this check because I can't think how this can ever be true. But please correct me if I am wrong.
ramioh
commented
Oct 15, 2024
| var sheetStream = sheet.Open(); | ||
| var fullName = sheet.FullName; | ||
|
|
||
| var inputValues = _inputValueExtractor.ToValueDictionary(value); |
There was a problem hiding this comment.
This is where the new class is called: InputValueExtractor.ToValueDictionary()
shps951023
reviewed
Oct 15, 2024
There was a problem hiding this comment.
.NET 6.0 (LTS) end date is Nov 12, 2024, we will follow the date to upgrade next month.
shps951023
approved these changes
Oct 15, 2024
|
@ramioh 👍👍👍 If no other partner's feedback, PR will be merged Nov 12, 2024(.NET 6.0 (LTS) end date), and could we invite you to our team? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SaveByTemplate, for theExcelOpenXmlTemplateclass and its three files.InputValueExtractorFluentAssertionsin tests to help with asserting results in less code.