This repository has been archived by the owner on May 13, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 86
GL loader work #276
Merged
GL loader work #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfan5
force-pushed
the
glsym
branch
4 times, most recently
from
January 17, 2024 10:23
4d957d2
to
ceeb75c
Compare
@numberZero thoughts? |
Closed
sfan5
force-pushed
the
glsym
branch
8 times, most recently
from
February 17, 2024 00:09
3589028
to
c3dba94
Compare
sfan5
force-pushed
the
glsym
branch
4 times, most recently
from
February 17, 2024 00:44
a51df69
to
c1776ec
Compare
(after requested in IRC) I can confirm that OpenGL 2 still works (also with shaders) on Ubuntu/Linux, 64-bit. SDL2 / OpenGL 3 / OpenGL ES support not enabled. |
I can confirm that OpenGL (4.6) still works on Linux, with shaders. FSAA also still works. As stated above, only test on Linux. |
isn't this what it usually looks like when the Irrlicht shaders are missing? |
Yes, however I'm reasonably sure that they aren't missing. The assets ZIP has them at least. Edit: Added some debug output and loading them doesn't seem to be the issue: 02-18 15:32:07.331 31617 386 D Minetest: 2024-02-18 15:32:07: INFO[Main]: Irrlicht: Loaded 382 bytes for vertex shader Renderer2D.vsh 02-18 15:32:07.331 31617 386 D Minetest: 2024-02-18 15:32:07: INFO[Main]: Irrlicht: Loaded 334 bytes for frag shader Renderer2D.fsh 02-18 15:32:07.343 31617 386 D Minetest: 2024-02-18 15:32:07: INFO[Main]: Irrlicht: Loaded 382 bytes for vertex shader Renderer2D.vsh 02-18 15:32:07.343 31617 386 D Minetest: 2024-02-18 15:32:07: INFO[Main]: Irrlicht: Loaded 129 bytes for frag shader Renderer2D_noTex.fsh |
Fixed it. |
sfan5
force-pushed
the
glsym
branch
2 times, most recently
from
February 21, 2024 21:03
9a4ab61
to
3a55467
Compare
this makes the OpenGL 3 driver free of GL symbol references!
primary reason: The unified GLES2 driver requires OpenGL headers (really), which Android does not provide.
Problem: Since the removal of !_IRR_OPENGL_USE_EXTPOINTER_ we require some quite recent symbols to compile the legacy GL driver. (*) Since the previous commit we prefer including them via SDL but those are sometimes too old. (*) This was in fact always a problem since USE_EXTPOINTER is the default. I guess people just had recent enough headers usually.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
(not my fault?)COGLESCoreExtensionHandler
MakeCOGLES2ExtensionHandler
use loaderMakeCOGLES1ExtensionHandler
use loaderDrop unused exts and functions fromCOpenGLExtensionHandler
(big oof)MakeCOpenGLExtensionHandler
use loaderglext.h
?!Edit: I crossed half out because I'm not actually sure what the way forward is. The GLES2 driver has some sort of unified stuff where the new support code uses
GL
instead of direct calls, while I assume GLES1 is meant to be dropped and GL to be replaced by GL3.Edit 2: currently achieved goals:
macos is only possible with sdl now. possibly fixable by shipping a copy of glext.h (SDL doesn't work so well last time someone tested it)