minor fixes for KG scripts #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amva13
added
v2neurips
bug
|
Hi @abearab wpuld yoh like to write unit tests for Primekg api? If so and they pass we can approve your changes to main primekg class. Otherwise, I'll approve primekgdev soon. A |
|
Hi @amva13, I'll be happy to write unit tests and replace primekgdev with Primekg api. |
|
Ok great. You can make the changes in this PR and I'll review.
Sent from [Proton Mail](https://proton.me/mail/home) for iOS
…On Wed, May 8, 2024 at 5:44 PM, Abolfazl (Abe) ***@***.***(mailto:On Wed, May 8, 2024 at 5:44 PM, Abolfazl (Abe) <<a href=)> wrote:
Hi ***@***.***(https://github.com/amva13), I'll be happy to write unit tests and replace primekgdev with Primekg api.
—
Reply to this email directly, [view it on GitHub](#255 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/ACPVN6AJPKPQ2SJA5YNV2SLZBKMFPAVCNFSM6AAAAABG5PN4K2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBRGUZTEMJTGY).
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KnowledgeGraphandPrimeKGDevclassesprimekgapi, add primekg test #266