Cut verification/signing/proofs etc. time by half for 64bit machines #71
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This fork is quite an old fork of upstream, We've changed a lot since then.
https://github.com/rust-bitcoin/rust-secp256k1
This PR copies the
build.rs
from upstream (with some small changes for the zkp stuff and the fact that things aren't feature gated), the upside is proper detection of 64bit targets and passing the according preprocessor definitionsOn my 64bit laptop, before this PR:
After:
I do suggest to merge/rebase this repository from/on upstream, or manually copy the changes you want because the library got a lot better.
These are just some examples of good/important changes we've made to the library:
rust-bitcoin/rust-secp256k1#146
rust-bitcoin/rust-secp256k1#125
rust-bitcoin/rust-secp256k1#120
rust-bitcoin/rust-secp256k1#115
rust-bitcoin/rust-secp256k1#100
rust-bitcoin/rust-secp256k1#87
rust-bitcoin/rust-secp256k1#78
rust-bitcoin/rust-secp256k1#64
rust-bitcoin/rust-secp256k1#51
rust-bitcoin/rust-secp256k1#27