Fix: Resolve build failures by unsetting LD_LIBRARY_PATH and using st… #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dbuf (milkv-duo#133) The build process was failing due to the current working directory being present in the LD_LIBRARY_PATH, which can lead to unpredictable behavior and errors. This commit addresses the issue in two ways: 1. Unsetting LD_LIBRARY_PATH: Before invoking , the environment variable is explicitly unset. This ensures that the build process uses system libraries from standard locations, preventing conflicts with potentially outdated or incorrect libraries in the current working directory. 2. Using stdbuf -oL with make: The original command was replaced with . This forces line buffering of the output from , ensuring that build logs are displayed correctly and in a timely manner. This change addresses potential issues with buffering that could lead to incomplete or delayed log output. These changes together resolve the build failures reported in milkv-duo#133 and improve the reliability and consistency of the build process.
|
req rework |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Resolve build failures in WSL2 (Ubuntu 22.04) when building milkv-duo256m-sd (#133)
When building
milkv-duo256m-sdwithbuild.shon WSL2 (Ubuntu 22.04), the build process was failing due to issues independencies.shandbrmake. This commit addresses these problems:dependencies.sh: The script was failing due to the presence of the current working directory in the
LD_LIBRARY_PATHenvironment variable. This could lead to unpredictable behavior and incorrect builds. The issue has been resolved by forcibly unsettingLD_LIBRARY_PATHbefore the build process. This ensures the build uses system libraries from the correct locations, preventing conflicts.brmake: The use of
unbufferinbrmakewas causing an error:"unbuffer can't find package Expect while executing "package require Expect" (file "/usr/bin/unbuffer" line 6)". This has been corrected by replacingunbufferwithstdbuf -oL, which provides similar line-buffering functionality without the Expect dependency. This ensures correct and timely output of build logs.These changes resolve the build failures encountered on WSL2 (Ubuntu 22.04) and ensure a more robust and reliable build process for
milkv-duo256m-sd.And complited normaly worked and tested build on the board.