Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix assets lookup for precompiled assets #840

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix assets lookup for precompiled assets #840

wants to merge 2 commits into from

Conversation

SampsonCrowley
Copy link

  • use asset_manifest if available
  • gems missing from dev dependencies
  • remove static preset asset path in unit test that breaks tests for anyone without ENV variable set

@SampsonCrowley SampsonCrowley force-pushed the fix-assets-in-production branch 2 times, most recently from 280df27 to b58b2c3 Compare June 12, 2019 04:42
@SampsonCrowley
Fix assets lookup for precompiled assets
a1a8897 
    - use asset_manifest if available
    - gems missing from dev dependencies
    - remove static preset asset path in unit test that breaks tests for 
anyone without ENV variable set
@SampsonCrowley SampsonCrowley force-pushed the fix-assets-in-production branch from b58b2c3 to a1a8897 Compare June 12, 2019 23:10
unixmonkey
unixmonkey reviewed Oct 2, 2019
View reviewed changes
wicked_pdf.gemspec Outdated Show resolved Hide resolved
test/unit/wicked_pdf_test.rb Show resolved Hide resolved
lib/wicked_pdf/wicked_pdf_helper/assets.rb Show resolved Hide resolved
@FiloSpaTeam
Copy link

Even with this fix i have the same problem: 404 error for precompiled assets but, manifest contains them, precompiled asset is deployed and Wicked works outside Mailer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unixmonkey unixmonkey unixmonkey left review comments

Assignees
No one assigned
Labels
asset-helpers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SampsonCrowley @FiloSpaTeam @unixmonkey