Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version check hangs on ruby 3 with certain gem combination #1132

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Version check hangs on ruby 3 with certain gem combination #1132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/wicked_pdf/binary.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@ def xvfb_run_path
private

def retrieve_binary_version
_stdin, stdout, _stderr = Open3.popen3(@path + ' -V')
stdin, stdout, stderr = Open3.popen3(@path + ' -V')
stdin.close
stderr.close
parse_version_string(stdout.gets(nil))
rescue StandardError
default_version
Expand Down
Loading