Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add frozen_string_literal magic header #1128

Merged
merged 1 commit into from
Oct 27, 2024
Merged

Add frozen_string_literal magic header #1128

merged 1 commit into from
Oct 27, 2024

Conversation

n-rodriguez
Copy link
Contributor

Thank you!

@n-rodriguez n-rodriguez force-pushed the wip/frozen_strings branch 2 times, most recently from ac55a55 to 246b0a2 Compare October 11, 2024 21:47
@n-rodriguez
Copy link
Contributor Author

@unixmonkey rebased! thank you!

@n-rodriguez
Copy link
Contributor Author

ping @unixmonkey

@n-rodriguez
Copy link
Contributor Author

ping @unixmonkey

@n-rodriguez
Copy link
Contributor Author

n-rodriguez commented Oct 26, 2024 •
edited
Loading

This PR is here to avoid regressions. See: https://gist.github.com/fxn/bf4eed2505c76f4fca03ab48c43adc72#can-i-delete-the-magic-comments-in-ruby-34

@unixmonkey unixmonkey merged commit 5a4c76a into mileszs:master Oct 27, 2024
12 checks passed
@n-rodriguez n-rodriguez deleted the wip/frozen_strings branch October 27, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unixmonkey unixmonkey unixmonkey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@n-rodriguez @unixmonkey