Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add export for optimization module #975

Merged
merged 11 commits into from
Sep 14, 2022

Conversation

kristinagalik
Copy link
Contributor

Closes #963

Base automatically changed from json_schema_optimizer_module to master August 22, 2022 10:29
@kristinagalik kristinagalik linked an issue Aug 22, 2022 that may be closed by this pull request
@kristinagalik
Copy link
Contributor Author

Output from high_res_example_data

{
    "compatibility_graph": [
        {
            "donor_id": 1,
            "hla_compatibility_score": -2.0,
            "recipient_id": 1
        },
        {
            "donor_id": 1,
            "hla_compatibility_score": -1.0,
            "recipient_id": 2
        },
        {
            "donor_id": 2,
            "hla_compatibility_score": -1.0,
            "recipient_id": 1
        },
        {
            "donor_id": 2,
            "hla_compatibility_score": -2.0,
            "recipient_id": 2
        },
        {
            "donor_id": 3,
            "hla_compatibility_score": -1.0,
            "recipient_id": 1
        },
        {
            "donor_id": 3,
            "hla_compatibility_score": 0.0,
            "recipient_id": 2
        }
    ],
    "configuration": {
        "limitations": {
            "custom_algorithm_settings": {},
            "max_chain_length": 4,
            "max_cycle_length": 4
        },
        "scoring": [
            [
                {
                    "hla_compatibility_score": 1
                }
            ]
        ]
    },
    "pairs": [
        {
            "donor_id": 1,
            "recipient_id": 1
        },
        {
            "donor_id": 2,
            "recipient_id": 2
        },
        {
            "donor_id": 3,
            "recipient_id": null
        }
    ]
}

@kristinagalik kristinagalik marked this pull request as ready for review August 24, 2022 19:44
Copy link
Contributor Author

@kristinagalik kristinagalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kubantjan nejake otazky

txmatching/optimizer/optimizer_functions.py Outdated Show resolved Hide resolved
@kristinagalik
Copy link
Contributor Author

kristinagalik commented Aug 25, 2022

works but tests blocked by mild-blue/swagger-unittest#10

@kubantjan
Copy link
Member

@kristinagalik ten output me mate, co tam delaji -1 a -2 v hla_compatibility score? zaporny znamenaji, ze jsou to nevalidni dvojicky a vubec tam byt nemaji ne (mame tam neco jako -1 nevalidinic a -2 originalni donori) a ani jedno z toho tam nepatri, ten output by mel byt podle me jenom:

"compatibility_graph": [
{
"donor_id": 3,
"hla_compatibility_score": 0.0,
"recipient_id": 2
}
],

tests/web/test_optimizer_api.py Outdated Show resolved Hide resolved
txmatching/optimizer/optimizer_functions.py Show resolved Hide resolved
txmatching/optimizer/optimizer_functions.py Outdated Show resolved Hide resolved
@kubantjan
Copy link
Member

udelal jsem fix ve swagger tester mild-blue/swagger-unittest#11 verze 0.3.5 uz je nasazena na pypi, melo by stacit jen zvednout verzi.

@kristinagalik kristinagalik force-pushed the 963_add_export_for_optimization_module branch from ae30451 to 4c9969f Compare September 11, 2022 11:11
Copy link
Member

@kubantjan kubantjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pridal bych test, kde bude nejaky poradny output toho exportu a porovna se to jestli je to spravny, aby byl hezky videt ten example output (ted si myslim ze je to furt asi spatne, kdyz to vraci to skore -1?

tests/web/test_optimizer_api.py Outdated Show resolved Hide resolved
@kristinagalik kristinagalik force-pushed the 963_add_export_for_optimization_module branch from 5513f8a to 584d40b Compare September 12, 2022 18:47
@kubantjan kubantjan force-pushed the 963_add_export_for_optimization_module branch from 584d40b to a0c0d84 Compare September 14, 2022 07:46
@kubantjan kubantjan merged commit dfec563 into master Sep 14, 2022
@kubantjan kubantjan deleted the 963_add_export_for_optimization_module branch September 14, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add export for optimization module
2 participants