Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copying of SSH keys from WSL to Windows #135

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

guillaumehu
Copy link

When running in WSL, it looks like we are copying the id_rsa before creating them. In this PR, we check if we need to copy them after the creation.

I am not sure what to do if the Windows ssh config file did not changed, should we still copy the id_rsa ? I am referring to this line

@guillaumehu guillaumehu marked this pull request as ready for review December 17, 2024 18:15
@lebrice lebrice changed the title copy id_rsa wsl to windows Fix copying of SSH keys from WSL to Windows Dec 18, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.

Project coverage is 73.89%. Comparing base (63cc24f) to head (28e4067).

Files with missing lines Patch % Lines
milatools/cli/commands.py 0.00% 3 Missing ⚠️
milatools/cli/init_command.py 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
- Coverage   74.16%   73.89%   -0.27%     
==========================================
  Files          17       17              
  Lines        2307     2314       +7     
==========================================
- Hits         1711     1710       -1     
- Misses        596      604       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants