update templates/templates/debian.seed.j2 #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jsl6ul
commented
Feb 27, 2024
jsl6ul
commented
- remove/disable tasksel standard
- add net-tools package
- add full-upgrade
- remove/disable tasksel - add net-tools - add full-upgrade
btravouillon
requested changes
Feb 28, 2024
There was a problem hiding this comment.
This is a breaking change that will change the default behavior for current users of this role. Could you make this optional / configurable to not change the default?
Also, note that it is possible for someone to define their own seed file with cobbler_autoinstall_templates.
https://github.com/mila-iqia/ansible-role-cobbler/blob/v0.2.2/defaults/main.yml#L34-L47
|
I don't need to merge this code, I can work with a local copy to speed up my tests. That's fine. Case closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.