remove 'when is defined' in main.yml #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove conditions 'when is defined' for cobbler_distros, cobbler_profiles and cobbler_systems, to avoid silent failure. You have to define 'cobbler_systems: []' to maintain the same behavior, but if, for any reason, you have an error in cobbler_distros or cobbler_profiles, the task will not fail silently.
btravouillon
requested changes
Feb 28, 2024
we should probably define them, empty, in defaults/main. (no breaking change) |
set this vars empty as default. (to avoid a breaking change caused by deleting "when is defined") cobbler_distros: [] cobbler_profiles: [] cobbler_systems: []
btravouillon
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove conditions 'when is defined' for cobbler_distros, cobbler_profiles and cobbler_systems, to avoid silent failure.
You have to define 'cobbler_systems: []' to maintain the same behavior, but if, for any reason, you have an undefined var in cobbler_distros or cobbler_profiles, the task will not fail silently.