Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some small fixes for cmake macos build #525

Merged
merged 6 commits into from
Oct 21, 2023
Merged

Conversation

NaLiJa
Copy link
Contributor

@NaLiJa NaLiJa commented Oct 18, 2023

When building rlottie according to rlottie docs, the libs are in the build subdirectory, so cmake cannot find the inc folder. Adjusted search path.
The sample apps were broken on macos because the assets and data files were not added to the app bundle. Added file copying to bl_samlpes macro. Not sure if this is the preferred cmake way to get the files into the bundle without the need to list each file separately as resource.

At the moment the app bundles are not self contained yet when using libs from the system, e.g. via homebrew like freetype, glfw,... will create a separate PR for this later.

Copy link
Owner

@mikke89 mikke89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for another nice pull request!

I don't have any experience with bundles, and I'm not really able to test this. As longs as this mainly affects apple platforms, I'm fine with delegating and trusting users to update and maintain this. So I guess you can consider yourself the maintainer of this part from here-on out ;)

Please be aware of the (massive) CMake changes in #446. Maybe you could sync up with that at some point, and in particular read the CMake contributing guide. But I'm perfectly fine with integrating these smaller fixups here first.

By the way, I see that you're including some unrelated/older commits in this PR. It would be helpful if you could rebase with only the new (PR-related) commits on top of master.

CMakeLists.txt Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@mikke89 mikke89 added the build Build system and compilation label Oct 21, 2023
@NaLiJa
Copy link
Contributor Author

NaLiJa commented Oct 21, 2023

Hi there,

fixed the above! Yes, the SDIR was referring to the subdir as I need to copy the folder structure to the app bundle. Have renamed it!

Will also have a look at the refactored cmake and try to adapt!

I have with little steps started with looking into adding glfm as a backend, but I cannot say yet if this leads to anything useable.

@mikke89 mikke89 merged commit d3876e6 into mikke89:master Oct 21, 2023
13 checks passed
@mikke89
Copy link
Owner

mikke89 commented Oct 21, 2023

Thanks for the quick update!

I have with little steps started with looking into adding glfm as a backend, but I cannot say yet if this leads to anything useable.

Sounds interesting, let us know how it goes.

alml pushed a commit to alml/RmlUi that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build system and compilation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants