basic functionality of replay log working #62
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| public string Url; | ||
| public string Claims; | ||
|
|
||
| private Regex scpRegex = new Regex(@"scp=([^\;]+)", RegexOptions.Compiled); |
Check notice
Code scanning / CodeQL
Missed 'readonly' opportunity Note
| public string Claims; | ||
|
|
||
| private Regex scpRegex = new Regex(@"scp=([^\;]+)", RegexOptions.Compiled); | ||
| private Regex rolesRegex = new Regex(@"roles=([^\;]+)", RegexOptions.Compiled); |
Check notice
Code scanning / CodeQL
Missed 'readonly' opportunity Note
|
|
||
| private Regex scpRegex = new Regex(@"scp=([^\;]+)", RegexOptions.Compiled); | ||
| private Regex rolesRegex = new Regex(@"roles=([^\;]+)", RegexOptions.Compiled); | ||
| private Regex roleRegex = new Regex("\"(.*?)\"", RegexOptions.Compiled); |
Check notice
Code scanning / CodeQL
Missed 'readonly' opportunity Note
| } catch (Exception e) { | ||
| Console.WriteLine("Failed to add resource to tree: " + resource.Key + " " + e.Message); | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause Note
| [Fact] | ||
| public void ParseLog() | ||
| { | ||
| var logstream = new FileStream(@"C:\Users\darrmi\src\github\microsoftgraph\kibali\graphlog.json", FileMode.Open); |
Check warning
Code scanning / CodeQL
Missing Dispose call on local IDisposable Warning test
|
|
||
| if (failReason == null ) | ||
| { | ||
| acceptablePermissions = acceptableClaims.Select(c => c.Permission).ToList(); |
Check warning
Code scanning / CodeQL
Dereferenced variable may be null Warning
| failReason = "No matching method"; | ||
| } | ||
|
|
||
| if (failReason == null && !supportedSchemes.TryGetValue(entry.Scheme, out acceptableClaims)) |
Check warning
Code scanning / CodeQL
Dereferenced variable may be null Warning
This change as the
replaylogcommand to the KibaliToolUsing a logfile as described in the logentry.cs file, this command will compare the permissions required by the model vs permissions used by requests recorded in the log.
Microsoft Reviewers: Open in CodeFlow