Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apache Groovy syntax support for traits, records and var #189639

Closed
wants to merge 2 commits into from

Conversation

glaforge
Copy link

@glaforge glaforge commented Aug 4, 2023

Groovy added support for traits (introduced in v2.3) and records (in v4), and the var keyword as an alternative to def for defining variables (in v4)

Fixes #189638

Groovy added support for traits (introduced in v2.3) and records (in v4), and the var keyword as an alternative to def for defining variables (in v4)
Groovy syntax support for trait, record and var
Copy link
Member

@manekinekko manekinekko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulk-asert
Copy link

LGTM

@alexr00
Copy link
Member

alexr00 commented Aug 7, 2023

Thank you for the PR! We get our Groovy grammar from another OSS repo, so when we run the script to pull in changes from there each month any manual changes to the Groovy grammar will get overwritten. Unfortunately, the OSS project we rely on is no longer supported. The issue tracking finding a new grammar is here: #145097

@alexr00 alexr00 closed this Aug 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apache Groovy syntax support for traits, records and var
5 participants