Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix highlighting of multi-lined regexp in Groovy #145098

Closed
wants to merge 1 commit into from

Conversation

jycchoi
Copy link

@jycchoi jycchoi commented Mar 15, 2022

Apply textmate/groovy.tmbundle#20

This PR fixes #145097

@alexr00
Copy link
Member

alexr00 commented Mar 21, 2022

Thank you for the PR! As you pointed out, we get our groovy syntax highlighting grammar from https://github.com/textmate/groovy.tmbundle. Because of this, we don't want to deviate from what's on the main branch of that repo.

It does look like that repo unmaintained. I will re-purpose #145097 to track investigating a different grammar.

@alexr00 alexr00 closed this Mar 21, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider using a new grammar for Groovy: Failed to highlight multi-lined regexp in Groovy code
4 participants