Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rev pgsqltools version to 1.10.0, update exe name, add osx ARM runtime #123

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jpda
Copy link

@jpda jpda commented Jan 3, 2024

The tools version 1.1.0 (in the original extension) are too old to support Apple arm64; later revisions do support arm64 but use a different executable name. This PR:

  • updates config to use v1.10.0 of the pgsqltoolsservice (latest as of 2024/01)
  • updates the name of the executable used from pgtoolsservice_main to ossdbtoolsservice_main (to reflect the change in pgtoolsservice)
  • adds an arm64 runtime identifier to download the correct file name

@jpda
Copy link
Author

jpda commented Jan 3, 2024

@microsoft-github-policy-service agree

@jpda
Copy link
Author

jpda commented Jan 4, 2024

Here is a gist that references fixing it locally, I used this to unblock myself to at least use the extension https://gist.github.com/jpda/2c11dc11d51bf049aa364897c5c76085

#113
#117
#104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant