Move json data

[Thomas1664]

No description provided.

[BillyONeal]

I find this change very scary as we've had horrible bugs trying to move things around in the JSON DOM before. Do you have a benchmark showing this as meaningful?

[Thomas1664]

I find this change very scary as we've had horrible bugs trying to move things around in the JSON DOM before.

I don't think moving things around in the JSON DOM is scary as most of the moves are at the end of a scope so there's nothing special about them. However, I do see the argument that re-using a moved-from variable is a possible source of bugs.

Do you have a benchmark showing this as meaningful?

This PR improves the performance of create_dependency_graph_snapshot by 25% (105 us vs. 79 us).

[BillyONeal]

I don't think moving things around in the JSON DOM is scary as most of the moves are at the end of a scope so there's nothing special about them.

The thing with DOMs is that their contents are shared around by different components. Moving something that was actually a component of an overall DOM has been a bug we have written a lot of.

This PR improves the performance of create_dependency_graph_snapshot by 25% (105 us vs. 79 us).

What is that in the context of an overall command using this?

[autoantwort]

What is that in the context of an overall command using this?

This is only called after you build a package for seconds, minutes or hours.

[Thomas1664]

The thing with DOMs is that their contents are shared around by different components. Moving something that was actually a component of an overall DOM has been a bug we have written a lot of.

If you read the code, you'll notice that this is not an issue here. This kind of bug can be avoided by following best practices regarding const correctness and the single responsibility principle.

[talregev]

Why we are using json? Can we switch to yaml format?

[dg0yt]

YAML has its own set of problems. This is a what-about discussion and doesn't belong here.