Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the behavior of overlay-ports. #422

Merged
merged 7 commits into from
Nov 15, 2024

Conversation

BillyONeal
Copy link
Member

@BillyONeal BillyONeal commented Nov 2, 2024

These clarifications were originally written for microsoft/vcpkg-tool#1534 , which we have decided not to do. I kept things which were useful improvements on their own.

Copy link

@BillyONeal : Thanks for your contribution! The author(s) have been notified to review your proposed change.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

@BillyONeal BillyONeal changed the title Document "overlay-port-dirs". Clarify the behavior of overlay-ports. Nov 13, 2024

This comment was marked as outdated.

This comment was marked as outdated.

Copy link
Contributor

Learn Build status updates of commit 73caad9:

✅ Validation status: passed

File Status Preview URL Details
vcpkg/commands/common-options.md ✅Succeeded View
vcpkg/commands/help.md ✅Succeeded View
vcpkg/concepts/overlay-ports.md ✅Succeeded View
vcpkg/concepts/package-name-resolution.md ✅Succeeded View
vcpkg/reference/vcpkg-configuration-json.md ✅Succeeded View
vcpkg/users/config-environment.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

@BillyONeal BillyONeal requested a review from Neumann-A November 13, 2024 21:56
Copy link
Contributor

Learn Build status updates of commit 6962922:

✅ Validation status: passed

File Status Preview URL Details
vcpkg/commands/common-options.md ✅Succeeded View
vcpkg/commands/help.md ✅Succeeded View
vcpkg/concepts/overlay-ports.md ✅Succeeded View
vcpkg/concepts/package-name-resolution.md ✅Succeeded View
vcpkg/reference/vcpkg-configuration-json.md ✅Succeeded View
vcpkg/users/config-environment.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

Copy link
Contributor

Learn Build status updates of commit 6b6e78b:

✅ Validation status: passed

File Status Preview URL Details
vcpkg/commands/common-options.md ✅Succeeded View
vcpkg/commands/help.md ✅Succeeded View
vcpkg/concepts/overlay-ports.md ✅Succeeded View
vcpkg/concepts/package-name-resolution.md ✅Succeeded View
vcpkg/reference/vcpkg-configuration-json.md ✅Succeeded View
vcpkg/users/config-environment.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

@vicroms vicroms merged commit ee433a6 into microsoft:main Nov 15, 2024
2 checks passed
@BillyONeal BillyONeal deleted the overlay-port-dirs branch November 16, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants