Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing json5 parsing issue #470

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

polatengin
Copy link
Collaborator

@polatengin polatengin commented Sep 24, 2024

Fixes #466

When parsing manifest json files, no need to check if it's json5 (supports comments, unquoted keys, etc.) or json

jju.parse() method already support json and json5 formats.

test.json

{
  name: "test",
  version: "1.0.0",
  "publisher": "test",
  categories: ["test"],
  contributions: [
    {
      "id": "home",
      "type": "ms.vss-web.hub",
    }
  ],
  // A comment
}

test command

node ./_build/tfx-cli.js extension create --manifests ./_build/test.json --trace-level debug

@polatengin polatengin self-assigned this Sep 24, 2024
@polatengin polatengin requested review from a team as code owners September 24, 2024 23:42
@polatengin polatengin linked an issue Sep 24, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when writing debug logs
1 participant