-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix snmalloc::memmove reverse block copy. #689
fix snmalloc::memmove reverse block copy. #689
Conversation
The fuzzer is still unhappy:
The fuzzer seems to run correctly when using |
was just to fix the asan crash, I ll look at the rest later. Seems Arch::copy has a bug too for both memcpy/memmove tough. |
I think the following fixes the issue:
and
|
Seems these your last changes all your fuzzer tests pass with. |
Co-authored-by: SchrodingerZhu <[email protected]>
8730d12
to
36a3f2e
Compare
I haven't been paying attention, but it looks like the |
@devnexen, to address Wes's comment about CHERI, I think we really need to have a per Arch implementation of I think this is a larger change than you might want to do. I propose we revert #593 for now, and then we can add back support later. This way there is no time pressure to get this fixed. Is that okay with you? |
Yes that s the right thing to do. As for implementing CHERI I m not sure I really can w/o related h/w. |
No description provided.