Skip to content

Commit

Permalink
chore: mark 1.34.2 (#23242)
Browse files Browse the repository at this point in the history
  • Loading branch information
dgozman authored May 23, 2023
1 parent ba85623 commit 2f3d88f
Show file tree
Hide file tree
Showing 18 changed files with 91 additions and 91 deletions.
26 changes: 13 additions & 13 deletions docs/src/ci.md
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ jobs:
name: 'Playwright Tests'
runs-on: ubuntu-latest
container:
image: mcr.microsoft.com/playwright:v1.34.1-jammy
image: mcr.microsoft.com/playwright:v1.34.2-jammy
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
Expand All @@ -256,7 +256,7 @@ jobs:
name: 'Playwright Tests'
runs-on: ubuntu-latest
container:
image: mcr.microsoft.com/playwright/python:v1.34.1-jammy
image: mcr.microsoft.com/playwright/python:v1.34.2-jammy
steps:
- uses: actions/checkout@v3
- name: Set up Python
Expand Down Expand Up @@ -284,7 +284,7 @@ jobs:
name: 'Playwright Tests'
runs-on: ubuntu-latest
container:
image: mcr.microsoft.com/playwright/java:v1.34.1-jammy
image: mcr.microsoft.com/playwright/java:v1.34.2-jammy
steps:
- uses: actions/checkout@v3
- uses: actions/setup-java@v3
Expand All @@ -309,7 +309,7 @@ jobs:
name: 'Playwright Tests'
runs-on: ubuntu-latest
container:
image: mcr.microsoft.com/playwright/dotnet:v1.34.1-jammy
image: mcr.microsoft.com/playwright/dotnet:v1.34.2-jammy
steps:
- uses: actions/checkout@v3
- name: Setup dotnet
Expand Down Expand Up @@ -338,7 +338,7 @@ jobs:
name: 'Playwright Tests - ${{ matrix.project }} - Shard ${{ matrix.shardIndex }} of ${{ matrix.shardTotal }}'
runs-on: ubuntu-latest
container:
image: mcr.microsoft.com/playwright:v1.34.1-jammy
image: mcr.microsoft.com/playwright:v1.34.2-jammy
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -413,7 +413,7 @@ jobs:
- deployment: Run_E2E_Tests
pool:
vmImage: ubuntu-22.04
container: mcr.microsoft.com/playwright:v1.34.1-jammy
container: mcr.microsoft.com/playwright:v1.34.2-jammy
environment: testing
strategy:
runOnce:
Expand All @@ -439,7 +439,7 @@ jobs:
- deployment: Run_E2E_Tests
pool:
vmImage: ubuntu-22.04
container: mcr.microsoft.com/playwright:v1.34.1-jammy
container: mcr.microsoft.com/playwright:v1.34.2-jammy
environment: testing
strategy:
runOnce:
Expand Down Expand Up @@ -483,7 +483,7 @@ Running Playwright on CircleCI is very similar to running on GitHub Actions. In
executors:
pw-jammy-development:
docker:
- image: mcr.microsoft.com/playwright:v1.34.1-jammy
- image: mcr.microsoft.com/playwright:v1.34.2-jammy
```

Note: When using the docker agent definition, you are specifying the resource class of where playwright runs to the 'medium' tier [here](https://circleci.com/docs/configuration-reference?#docker-execution-environment). The default behavior of Playwright is to set the number of workers to the detected core count (2 in the case of the medium tier). Overriding the number of workers to greater than this number will cause unnecessary timeouts and failures.
Expand All @@ -507,7 +507,7 @@ to run tests on Jenkins.

```groovy
pipeline {
agent { docker { image 'mcr.microsoft.com/playwright:v1.34.1-jammy' } }
agent { docker { image 'mcr.microsoft.com/playwright:v1.34.2-jammy' } }
stages {
stage('e2e-tests') {
steps {
Expand All @@ -525,7 +525,7 @@ pipeline {
Bitbucket Pipelines can use public [Docker images as build environments](https://confluence.atlassian.com/bitbucket/use-docker-images-as-build-environments-792298897.html). To run Playwright tests on Bitbucket, use our public Docker image ([see Dockerfile](./docker.md)).

```yml
image: mcr.microsoft.com/playwright:v1.34.1-jammy
image: mcr.microsoft.com/playwright:v1.34.2-jammy
```

### GitLab CI
Expand All @@ -538,7 +538,7 @@ stages:
tests:
stage: test
image: mcr.microsoft.com/playwright:v1.34.1-jammy
image: mcr.microsoft.com/playwright:v1.34.2-jammy
script:
...
```
Expand All @@ -554,7 +554,7 @@ stages:
tests:
stage: test
image: mcr.microsoft.com/playwright:v1.34.1-jammy
image: mcr.microsoft.com/playwright:v1.34.2-jammy
parallel: 7
script:
- npm ci
Expand All @@ -569,7 +569,7 @@ stages:
tests:
stage: test
image: mcr.microsoft.com/playwright:v1.34.1-jammy
image: mcr.microsoft.com/playwright:v1.34.2-jammy
parallel:
matrix:
- PROJECT: ['chromium', 'webkit']
Expand Down
24 changes: 12 additions & 12 deletions docs/src/docker.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,19 +18,19 @@ This Docker image is intended to be used for testing and development purposes on
### Pull the image

```bash js
docker pull mcr.microsoft.com/playwright:v1.34.1-jammy
docker pull mcr.microsoft.com/playwright:v1.34.2-jammy
```

```bash python
docker pull mcr.microsoft.com/playwright/python:v1.34.1-jammy
docker pull mcr.microsoft.com/playwright/python:v1.34.2-jammy
```

```bash csharp
docker pull mcr.microsoft.com/playwright/dotnet:v1.34.1-jammy
docker pull mcr.microsoft.com/playwright/dotnet:v1.34.2-jammy
```

```bash java
docker pull mcr.microsoft.com/playwright/java:v1.34.1-jammy
docker pull mcr.microsoft.com/playwright/java:v1.34.2-jammy
```

### Run the image
Expand All @@ -42,39 +42,39 @@ By default, the Docker image will use the `root` user to run the browsers. This
On trusted websites, you can avoid creating a separate user and use root for it since you trust the code which will run on the browsers.

```bash js
docker run -it --rm --ipc=host mcr.microsoft.com/playwright:v1.34.1-jammy /bin/bash
docker run -it --rm --ipc=host mcr.microsoft.com/playwright:v1.34.2-jammy /bin/bash
```

```bash python
docker run -it --rm --ipc=host mcr.microsoft.com/playwright/python:v1.34.1-jammy /bin/bash
docker run -it --rm --ipc=host mcr.microsoft.com/playwright/python:v1.34.2-jammy /bin/bash
```

```bash csharp
docker run -it --rm --ipc=host mcr.microsoft.com/playwright/dotnet:v1.34.1-jammy /bin/bash
docker run -it --rm --ipc=host mcr.microsoft.com/playwright/dotnet:v1.34.2-jammy /bin/bash
```

```bash java
docker run -it --rm --ipc=host mcr.microsoft.com/playwright/java:v1.34.1-jammy /bin/bash
docker run -it --rm --ipc=host mcr.microsoft.com/playwright/java:v1.34.2-jammy /bin/bash
```

#### Crawling and scraping

On untrusted websites, it's recommended to use a separate user for launching the browsers in combination with the seccomp profile. Inside the container or if you are using the Docker image as a base image you have to use `adduser` for it.

```bash js
docker run -it --rm --ipc=host --user pwuser --security-opt seccomp=seccomp_profile.json mcr.microsoft.com/playwright:v1.34.1-jammy /bin/bash
docker run -it --rm --ipc=host --user pwuser --security-opt seccomp=seccomp_profile.json mcr.microsoft.com/playwright:v1.34.2-jammy /bin/bash
```

```bash python
docker run -it --rm --ipc=host --user pwuser --security-opt seccomp=seccomp_profile.json mcr.microsoft.com/playwright/python:v1.34.1-jammy /bin/bash
docker run -it --rm --ipc=host --user pwuser --security-opt seccomp=seccomp_profile.json mcr.microsoft.com/playwright/python:v1.34.2-jammy /bin/bash
```

```bash csharp
docker run -it --rm --ipc=host --user pwuser --security-opt seccomp=seccomp_profile.json mcr.microsoft.com/playwright/dotnet:v1.34.1-jammy /bin/bash
docker run -it --rm --ipc=host --user pwuser --security-opt seccomp=seccomp_profile.json mcr.microsoft.com/playwright/dotnet:v1.34.2-jammy /bin/bash
```

```bash java
docker run -it --rm --ipc=host --user pwuser --security-opt seccomp=seccomp_profile.json mcr.microsoft.com/playwright/java:v1.34.1-jammy /bin/bash
docker run -it --rm --ipc=host --user pwuser --security-opt seccomp=seccomp_profile.json mcr.microsoft.com/playwright/java:v1.34.2-jammy /bin/bash
```

[`seccomp_profile.json`](https://github.com/microsoft/playwright/blob/main/utils/docker/seccomp_profile.json) is needed to run Chromium with sandbox. This is a [default Docker seccomp profile](https://github.com/docker/engine/blob/d0d99b04cf6e00ed3fc27e81fc3d94e7eda70af3/profiles/seccomp/default.json) with extra user namespace cloning permissions:
Expand Down
2 changes: 1 addition & 1 deletion docs/src/test-snapshots-js.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ The snapshot name `example-test-1-chromium-darwin.png` consists of a few parts:
If you are not on the same operating system as your CI system, you can use Docker to generate/update the screenshots:

```bash
docker run --rm --network host -v $(pwd):/work/ -w /work/ -it mcr.microsoft.com/playwright:v1.34.1-jammy /bin/bash
docker run --rm --network host -v $(pwd):/work/ -w /work/ -it mcr.microsoft.com/playwright:v1.34.2-jammy /bin/bash
npm install
npx playwright test --update-snapshots
```
Expand Down
Loading

0 comments on commit 2f3d88f

Please sign in to comment.