Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CommitmentDiscountUsage transform to use parse_resourceid #1219

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

flanakin
Copy link
Collaborator

πŸ› οΈ Description

Update CommitmentDiscountUsage_transform_v1_0() to use parse_resourceid()

πŸ“‹ Checklist

πŸ”¬ How did you test this change?

  • 🀏 Lint tests
  • 🀞 PS -WhatIf / az validate
  • πŸ‘ Manually deployed + verified
  • πŸ’ͺ Unit tests
  • πŸ™Œ Integration tests

πŸ™‹β€β™€οΈ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🀏 The change is less than 20 lines of code.

πŸ“‘ Did you update docs/changelog.md?

  • βœ… Updated changelog (required for dev PRs)
  • ➑️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

πŸ“– Did you update documentation?

  • βœ… Public docs in docs (required for dev)
  • βœ… Internal dev docs in src (required for dev)
  • ➑️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@flanakin flanakin added this to the 2024-12 - December milestone Dec 16, 2024
@flanakin flanakin requested a review from MSBrett as a code owner December 16, 2024 01:51
@flanakin flanakin requested review from Copilot and removed request for MSBrett December 16, 2024 01:51

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/templates/finops-hub/modules/scripts/IngestionSetup.kql:1248

  • Ensure that the new behavior introduced by parse_resourceid is covered by unit or integration tests.
| extend tmp_ResourceDetails = parse_resourceid(ResourceId)
@microsoft-github-policy-service microsoft-github-policy-service bot added Micro PR πŸ”¬ Very small PR that should be especially easy for newcomers Needs: Review πŸ‘€ PR that is ready to be reviewed labels Dec 16, 2024
@flanakin flanakin requested a review from bwatts64 December 16, 2024 01:55
@flanakin flanakin added the Tool: FinOps hubs Data pipeline solution label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Micro PR πŸ”¬ Very small PR that should be especially easy for newcomers Needs: Review πŸ‘€ PR that is ready to be reviewed Tool: FinOps hubs Data pipeline solution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants