Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docker file path for python runtime images #2364

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix docker file path for python runtime images #2364

wants to merge 1 commit into from

Conversation

kumaraksh1
Copy link
Collaborator

@kumaraksh1 kumaraksh1 commented Feb 23, 2024 •
edited
Loading

  • The purpose of this PR is explained in this message or in an issue. If an issue please include a reference as #<issue_number>.
  • Tests are included and/or updated for code changes.
  • Proper license headers are included in each file.

To generate the runtime base images, dockerfiles are generated on the fly and the same file is used to create the image.
While creating the docker files for Python, path is different from what is used while building the image.

Look here.
https://github.com/microsoft/Oryx/blob/8b3ac454331efe1b7934439f06cc7ece42c01613/build/buildRunTimeImageBases.sh#L80C1-L80C59

Tested the change with the PR - https://github.com/microsoft/Oryx/pull/2359/files

@kumaraksh1 kumaraksh1 requested a review from a team as a code owner February 23, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarsharma sarsharma sarsharma approved these changes

@surenderssm surenderssm surenderssm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kumaraksh1 @surenderssm @sarsharma