[ci] add yaml files linter to pre-commit hook but skip some rules for now (Part 1) #6763
+19
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikerRUS
requested review from
guolinke,
jameslamb,
shiyu1994,
jmoralez and
borchero
as code owners
jameslamb
requested changes
Dec 18, 2024
| rev: v1.35.1 | ||
| hooks: | ||
| - id: yamllint | ||
| args: ["--strict"] |
There was a problem hiding this comment.
This will be a bit disruptive to local development.. running pre-commit run --all-files locally (which I do many times during local development)... will produce a lot of output and fail until we've fixed all the issues.
Would you consider the following instead?
- add all the rules that currently produce errors to
.yamllint.ymlin this PR with:disable - remove the
SKIP=yamllintinlint-python-bash.sh - enable more and more rules over each of the next set of PRs.
That would prevent any new issues from being introduced on master while allowing pre-commit run --all-files to continue working locally.
There was a problem hiding this comment.
Makes sense! Thank you very much for the suggestion! I just pushed 4adf207 with these changes.
StrikerRUS
changed the title
|
@borchero Could you please take a look when have time? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR in series of PRs for linting yaml files.
See #6758 for background and future PRs' content required to fix all errors with the proposed config.
List of generated errors with the proposed config: https://github.com/microsoft/LightGBM/actions/runs/12383831332/job/34567296571#step:3:886.
List of available linter rules: https://yamllint.readthedocs.io/en/stable/rules.html.
Won't merge this PR without reviews from @borchero and @jameslamb (#6758 (comment)).