Add dynamic capability using regex #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| else if (expected === actual) | ||
| return true; | ||
| else if ((typeof expected === "object" && expected !== null) && (typeof actual === "object" && actual !== null)) { | ||
| for (var prop in expected) { |
There was a problem hiding this comment.
Should also check that number of attributes to ensure deep equality.
There was a problem hiding this comment.
This will conflict with what we did in the transformation script, kindly consult with Amir on how/when we should use this deepEqual method and get back to me.
memassamara
force-pushed
the
Add_dynamic_capability_using_regex
branch
from
666badf to
b6d3c7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.