Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MMAP-8: Json-editor v2.2.1 #50

Merged
merged 44 commits into from
May 19, 2020
Merged

MMAP-8: Json-editor v2.2.1 #50

merged 44 commits into from
May 19, 2020

Conversation

Danielecina
Copy link
Member

@Danielecina Danielecina commented May 11, 2020 •
edited by davidebianchi
Loading

🧰 What's being changed?

Update:

  • @Json-editor/Json-editor to V2.2.1

Change

  • General align styles to requested design

Fix:

  • removed yarn-lock to repository
  • Blocked Fetch-har to V2.0.0 because of bug V2.3.1

🗳 Checklist

💡 If answering yes to any of the following, include additional info, before/after links, screenshots, etc. where appropriate!
Schermata 2020-05-11 alle 18 42 59

  • 🆕 I'm adding something new!
  • 🐛 I'm fixing a bug!
  • 📸 I've made some changes to the UI!

davidebianchi
davidebianchi requested changes May 11, 2020
View reviewed changes
.babelrc Show resolved Hide resolved
example/src/SpecFetcher.jsx Outdated Show resolved Hide resolved
example/swagger-files/petstore.json Outdated Show resolved Hide resolved
packages/api-explorer/__tests__/AuthBox.test.jsx Show resolved Hide resolved
packages/api-explorer/__tests__/JsonForm/index.test.jsx Show resolved Hide resolved
packages/api-explorer/src/JsonForm/antd-theme-json-editor.js Outdated Show resolved Hide resolved
packages/api-explorer/src/JsonForm/configureJsonEditor.js Outdated Show resolved Hide resolved
packages/api-explorer/package.json Outdated Show resolved Hide resolved
packages/api-explorer/src/JsonForm/index.jsx Outdated Show resolved Hide resolved
packages/api-explorer/src/block-types/Parameters.jsx Outdated Show resolved Hide resolved
@fredmaggiowski fredmaggiowski added the enhancement New feature or request label May 12, 2020
davidebianchi
davidebianchi requested changes May 12, 2020
View reviewed changes
packages/api-explorer/__tests__/CopyCode.test.jsx Outdated Show resolved Hide resolved
packages/api-explorer/__tests__/JsonForm/index.test.jsx Outdated Show resolved Hide resolved
packages/api-explorer/__tests__/JsonForm/index.test.jsx Outdated Show resolved Hide resolved
packages/api-explorer/__tests__/JsonForm/index.test.jsx Outdated Show resolved Hide resolved
packages/api-explorer/__tests__/JsonForm/resolveReference.test.jsx Outdated Show resolved Hide resolved
packages/api-explorer/__tests__/Params.test.jsx Outdated Show resolved Hide resolved
packages/api-explorer/src/JsonForm/configureJsonEditor.js Show resolved Hide resolved
packages/api-explorer/src/JsonForm/index.jsx Outdated Show resolved Hide resolved
packages/api-explorer/src/JsonForm/resolveReference.js Outdated Show resolved Hide resolved
packages/api-explorer/src/index.jsx Show resolved Hide resolved
fredmaggiowski
fredmaggiowski requested changes May 13, 2020
View reviewed changes
Copy link
Member

@fredmaggiowski fredmaggiowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, some minor improvements to be done but we're almost ready to merge it! :)

packages/api-explorer/__tests__/JsonForm/index.test.jsx Outdated Show resolved Hide resolved
packages/api-explorer/__tests__/JsonForm/resolveReference.test.jsx Outdated Show resolved Hide resolved
packages/api-explorer/__tests__/JsonForm/resolveReference.test.jsx Outdated Show resolved Hide resolved
packages/api-explorer/__tests__/JsonForm/resolveReference.test.jsx Outdated Show resolved Hide resolved
packages/api-explorer/__tests__/JsonForm/resolveReference.test.jsx Outdated Show resolved Hide resolved
packages/api-explorer/package.json Show resolved Hide resolved
packages/api-explorer/src/JsonForm/custom-bootstrap4.css Show resolved Hide resolved
packages/api-explorer/src/JsonForm/index.jsx Outdated Show resolved Hide resolved
packages/api-explorer/src/JsonForm/objects-editor.js Outdated Show resolved Hide resolved
packages/api-explorer/src/index.jsx Show resolved Hide resolved
@fredmaggiowski
Copy link
Member

When using file circular.json the package breaks for a Uncaught RangeError: Maximum call stack size exceeded

@fredmaggiowski fredmaggiowski self-requested a review May 13, 2020 11:18
davidebianchi
davidebianchi requested changes May 19, 2020
View reviewed changes
packages/api-explorer/__tests__/JsonForm/index.test.jsx Outdated Show resolved Hide resolved
packages/api-explorer/package.json Outdated Show resolved Hide resolved
packages/api-explorer/package.json Outdated Show resolved Hide resolved
packages/api-explorer/src/JsonForm/refReplacer.js Show resolved Hide resolved
packages/api-explorer/src/JsonForm/refReplacer.js Outdated Show resolved Hide resolved
packages/api-explorer/src/JsonForm/refReplacer.js Outdated Show resolved Hide resolved
packages/api-explorer/src/JsonForm/resolveRootRef.js Outdated Show resolved Hide resolved
@dibericky dibericky merged commit 5352089 into master May 19, 2020
@davidebianchi davidebianchi deleted the MMAP-8-editor-v2 branch May 19, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibericky dibericky dibericky left review comments

@davidebianchi davidebianchi davidebianchi approved these changes

@fredmaggiowski fredmaggiowski fredmaggiowski approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Danielecina @fredmaggiowski @dibericky @davidebianchi