Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oanda bar price handler #174

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

tomhunter-gh
Copy link

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 64.8% when pulling cf4a081 on tomhunter-gh:master into 2714ae4 on mhallsmoore:master.

1 similar comment
@coveralls
Copy link

coveralls commented Feb 12, 2017

Coverage Status

Coverage increased (+0.8%) to 64.8% when pulling cf4a081 on tomhunter-gh:master into 2714ae4 on mhallsmoore:master.

@tomhunter-gh
Copy link
Author

Hi @mhallsmoore, please let me know if you have any thoughts or comments on the above pull request.

A strategy I'm currently trying to code relies upon bar returns that are calculated based on the difference in opening prices. In other words (in live trading) the calculate_signals method should only produce a signal when it has seen the open_price on a new incomplete candle. I'm thinking this means that the price handler has to effectively supply every candle twice, once as an incomplete candle with no close price, and a second time with a close price. I will work on this next.

@mhallsmoore
Copy link
Owner

Hi Tom,

Thanks for making this pull request I'll be taking a good look through it and I'll provide some feedback.

By the way - do you currently have access to the Slack development chat/channel? If not, you can email me at [email protected] and I'll send you a Slack invite...

Cheers,

Mike.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants