-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inventory Tweaks Tree sorting 1.16 #2380
base: 1.16
Are you sure you want to change the base?
Conversation
https://github.com/IMarvinTPA/JustEnoughItems into customSorting_1.16 # Conflicts: # src/main/java/mezz/jei/ingredients/IIngredientListElementInfo.java
Isn't Inventory Tweaks discontinued (especially in 1.13+)? Wouldn't it be better to reuse sorting rules from one of the modern and still maintained mods instead, such as: Inventory Profiles (IMO the best one as it has client-side sorting), Inventory Sorter (made by cpw), Inventory Tweaks Renewed, etc.? |
I'm in the middle of adding the tree sorting feature to Inventory Tweaks Renewed, but I need to spend a fair bit of time with the network syncing code and have made no attempt yet at that. The reason I keep adding some form of Inventory Tweaks sorting to JEI is that it is the easiest way to find a display that shows "all the things" and test out the sorter, identify what's missing and add it to the file. |
This should definitely be an API call and not all included in here. I can help with this later. |
@mezz Ok. I'll make a new pull request for just the sorting config bits. I think I'm almost done getting InventoryTweaksRenewed working properly. |
This has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions. |
I hope this makes it in, but I would understand if it does not. If not, can you help me understand how to make an API that would register a new comparator? I don't think the ENum IngredientSortStage makes adding new ones easy.